fix: conversion of LF to CRLF #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Beltran <[email protected]>
bjohansebas
approved these changes
May 30, 2025
Member
bjohansebas
left a comment
bjohansebas
left a comment
There was a problem hiding this comment.
thanks for the PR! I’d like to know if you could try adding tests to verify the behavior, no problem if you can’t.
Contributor
Author
|
Vacation. In a couple weeks I can get to it ☀️🌴🌊 |
Contributor
Author
|
i found a minute and added some tests for the EOL detection. not sure if you want to do more for testing the transforms? |
Signed-off-by: Sebastian Beltran <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on Windows with a repo that uses LF as EOL, the codemod converts all LF to CRLF leading to unwanted diffs (diffs on 804 files in our Verdaccio repo).
This PR detects the EOL used in modified files and passes it as an option to
jscodeshift(which will pass it torecast).